Skip to content

docs: update docs/ja #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2018
Merged

docs: update docs/ja #729

merged 1 commit into from
Jul 19, 2018

Conversation

38elements
Copy link
Contributor

@38elements 38elements commented Jun 16, 2018 •
edited
Loading

This is related to #728.

@38elements 38elements mentioned this pull request Jun 17, 2018
Merged
@kazupon
Copy link
Member

kazupon commented Jun 18, 2018

#722 duplicate?

@38elements
Copy link
Contributor Author

38elements commented Jun 18, 2018 •
edited
Loading

No, it is not.
There is #700.
Since #728 will be merged, #722 is not necessary to merge.
Currently, existing api documents are incorrect.
https://github.com/vuejs/vue-test-utils/pull/728/files
This pull request includes #728.

@38elements
Copy link
Contributor Author

@kazupon
大変申し訳ございません。
レビューは #728 がマージされた後にしていただけないでしょうか。
よろしくお願いします。

@kazupon
Copy link
Member

kazupon commented Jun 18, 2018

Thanks for your explanation!
It's a okay!

@38elements 38elements force-pushed the document branch 2 times, most recently from ab339df to 83fb2cb Compare June 19, 2018 12:46
@38elements
Copy link
Contributor Author

38elements commented Jun 19, 2018 •
edited
Loading

#737 を反映しました。
よろしくお願いします。

@38elements 38elements force-pushed the document branch 3 times, most recently from 629b8b1 to 60dcd8d Compare June 23, 2018 12:52
@38elements
Copy link
Contributor Author

@kazupon
Thank you for reviewing.

eddyerburgh
eddyerburgh approved these changes Jul 19, 2018
View reviewed changes
Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translations :)

@eddyerburgh eddyerburgh merged commit 42c15d5 into vuejs:dev Jul 19, 2018
@38elements 38elements deleted the document branch July 20, 2018 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

@eddyerburgh eddyerburgh eddyerburgh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@38elements @kazupon @eddyerburgh